Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: Fix shader parsing #14049

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jul 14, 2023

See https://forum.babylonjs.com/t/app-that-worked-for-months-using-nme-materials-suddenly-hangs-with-shader-errors/42441/8

The problem is a bug in PerturbNormal (that does not remove a ";" in some injected shader code), but which was hidden by the way we parsed the shader code before #13935.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan enabled auto-merge July 14, 2023 18:32
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2023

@sebavan sebavan merged commit 519745d into BabylonJS:master Jul 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants